Skip to content

fix(plugin-form): render list box options at natural height with opaque background #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Falkyouall wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(plugin-form): render list box options at natural height with opaque background #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/form-listbox-rendering.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@embedpdf/plugin-form': patch
---

Fix list box form widgets rendering unusably when the option count exceeds the widget height. Option rows now carry `flexShrink: 0`, so they keep their natural line height and the container scrolls instead of the flex column crushing all rows into the box. The overlay background now treats a missing or `transparent` annotation color as opaque white, so the widget's appearance-stream image no longer shows through and doubles the option text. Applied to both the interactive form-fill list box and the annotation-mode renderer.
5 changes: 4 additions & 1 deletion packages/plugin-form/src/shared/components/annotations/form-listbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ export function FormListbox({ annotation, isSelected, scale, onClick, style }: F
style={{
position: 'absolute',
inset: 0,
background: object.color ?? '#FFFFFF',
// The overlay redraws the option list itself, so it must fully cover the
// appearance-stream image behind it — treat 'transparent' as opaque white.
background: !object.color || object.color === 'transparent' ? '#FFFFFF' : object.color,
border: `${borderWidth}px solid ${object.strokeColor ?? '#000000'}`,
outline: isHovered || isSelected ? '1px solid rgba(66, 133, 244, 0.5)' : 'none',
outlineOffset: -1,
Expand All @@ -50,6 +52,7 @@ export function FormListbox({ annotation, isSelected, scale, onClick, style }: F
<div
key={i}
style={{
flexShrink: 0,
padding: `0 ${4 * scale}px`,
fontSize,
lineHeight: `${lineHeight}px`,
Expand Down
6 changes: 5 additions & 1 deletion packages/plugin-form/src/shared/components/fields/listbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ export function ListboxField(props: ListboxFieldProps) {
left: 0,
width: '100%',
height: '100%',
background: annotation.color ?? '#FFFFFF',
// The overlay redraws the option list itself, so it must fully cover the
// appearance-stream image behind it — treat 'transparent' as opaque white.
background:
!annotation.color || annotation.color === 'transparent' ? '#FFFFFF' : annotation.color,
borderStyle: 'solid',
borderColor: annotation.strokeColor ?? '#000000',
borderWidth: bw,
Expand Down Expand Up @@ -63,6 +66,7 @@ export function ListboxField(props: ListboxFieldProps) {
key={i}
onClick={() => handleOptionClick(i)}
style={{
flexShrink: 0,
padding: `0 ${4 * scale}px`,
fontSize,
lineHeight: `${lineHeight}px`,
Expand Down