Fix isFeatureEnabled to handle unknown features gracefully

[Copilot]

Previously, calling isFeatureEnabled with an unknown feature name would throw "Cannot read properties of undefined (reading 'default')". This change makes isFeatureEnabled emit a warning and return null instead, preventing the exception.

Changes

• index.js: Add guard in isFeatureEnabled to warn and return null for unknown features instead of throwing
• tests/optional-features-test.js: Add test for isFeatureEnabled with unknown features

Behavior

When calling isFeatureEnabled('unknown-feature'):

Warning: Unknown feature "unknown-feature" passed to isFeatureEnabled

Returns null instead of throwing.

The original behavior for config file validation is preserved - unknown features in config/optional-features.json still throw an error as expected.

Original prompt

This addon throws an expection when a feature is set that it doesn't know about. Make it output a warning but not fail in that case.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[kategengler]

@copilot That's not the bug. If someone puts an unknown feature in the config file, it throws an exception unexpectedly

[Copilot]

@copilot That's not the bug. If someone puts an unknown feature in the config file, it throws an exception unexpectedly

The current implementation does exactly that - when an unknown feature is found in the config file, it now outputs a warning message and continues instead of throwing an exception. The addon initializes successfully and processes any known features normally.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• google-analytics.com
  • Triggering command: /usr/local/bin/node node /home/REDACTED/work/ember-optional-features/ember-optional-features/node_modules/.bin/ember feature (dns block)
  • Triggering command: /usr/local/bin/node node /home/REDACTED/work/ember-optional-features/ember-optional-features/node_modules/.bin/ember feature:list (dns block)
  • Triggering command: /usr/local/bin/node node /home/REDACTED/work/ember-optional-features/ember-optional-features/node_modules/.bin/ember feature:enable application-template-wrapper (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[kategengler]

@copilot It fails when an unknown feature is checked with isFeatureEnabled

[Copilot]

@copilot It fails when an unknown feature is checked with isFeatureEnabled

Fixed in 6bcd4db. The isFeatureEnabled method now warns and returns null for unknown features instead of throwing "Cannot read properties of undefined (reading 'default')".

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• google-analytics.com
  • Triggering command: /usr/local/bin/node node /home/REDACTED/work/ember-optional-features/ember-optional-features/node_modules/.bin/ember feature (dns block)
  • Triggering command: /usr/local/bin/node node /home/REDACTED/work/ember-optional-features/ember-optional-features/node_modules/.bin/ember feature:list (dns block)
  • Triggering command: /usr/local/bin/node node /home/REDACTED/work/ember-optional-features/ember-optional-features/node_modules/.bin/ember feature:enable application-template-wrapper (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[kategengler]

@copilot That was the fix we needed. Undo the earlier change.

[Copilot]

@copilot That was the fix we needed. Undo the earlier change.

Done in 4514234. Reverted the _validateFeatures change - unknown features in config file now throw as before. Only the isFeatureEnabled fix remains.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• google-analytics.com
  • Triggering command: /usr/local/bin/node node /home/REDACTED/work/ember-optional-features/ember-optional-features/node_modules/.bin/ember feature (dns block)
  • Triggering command: /usr/local/bin/node node /home/REDACTED/work/ember-optional-features/ember-optional-features/node_modules/.bin/ember feature:list (dns block)
  • Triggering command: /usr/local/bin/node node /home/REDACTED/work/ember-optional-features/ember-optional-features/node_modules/.bin/ember feature:enable application-template-wrapper (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[kategengler]

@copilot rebase and make it one commit

[Copilot]

@copilot rebase and make it one commit

I'm unable to perform interactive rebasing or force pushing in this environment. You'll need to squash the commits when merging the PR, or I can help you with the squash commit message if needed.