[CLEANUP] Remove DEPRECATE_TEMPLATE_ACTION #20882

tcjr · 2025-03-22T16:17:11Z

Related to #20816.

The cleanup for this deprecation is pretty substantial, as it completely deletes two longstanding pieces of code from the resolver: the action modifier and the action helper. One consequence of this is that action is no longer a built-in keyword and can presumably be used now like any other helper and modifier.

tcjr · 2025-03-24T22:12:15Z

@NullVoxPopuli @kategengler I restored the non-modifer parts of the modifier source file. All lints and tests and checks pass locally.

I am not sure how much of that very old event dispatcher code is in use anymore. Maybe "send" or some other old event mechanism still hits that code path.

kategengler · 2025-03-24T22:56:30Z

While we deprecated and remove the action modifier and helper we didn't deprecate or remove the actions hash or the TargetActionSupport stuff https://github.com/emberjs/rfcs/blob/deprecate-target-action-support/text/0000-deprecate-target-action-support.md has some more info.

tcjr · 2025-03-24T23:08:49Z

In a post-{{action}} modifier world, should we just remove this test?

  QUnit.test('Should not attempt to render element modifiers GH#14220', function (assert) {
    assert.expect(1);

    this.template('application', "<div {{action 'foo'}}></div>");

    return this.renderToHTML('/').then(function (html) {
      assert.htmlMatches(html, '<body><div></div></body>');
    });
  });

From app-boot-test.js

NullVoxPopuli · 2025-03-24T23:14:23Z

In a post-{{action}} modifier world, should we just remove this test?

We could replace action with on

tcjr · 2025-03-24T23:18:21Z

We could replace action with on

I believe this a FastBoot test that is verifying that a modifier that adds something to the DOM doesn't do it in the FastBoot context. For {{action}}, it adds a data- attribute. The on modifier doesn't modify the DOM (afaik), so I think we would need to create one for this test that changes the HTML.

packages/@ember/-internals/glimmer/lib/resolver.ts

github-actions · 2025-03-26T00:28:45Z

Development Assets

Diff

--- main/out.txt	2025-03-26 03:14:18.000000000 +0000
+++ pr/./pr-14129674314/out.txt	2025-03-28 15:59:38.000000000 +0000
@@ -1,4 +1,4 @@
- 2.3M └─┬ .
+ 2.2M └─┬ .
 1015K   ├─┬ @ember
  206K   │ ├─┬ -internals
   69K   │ │ ├─┬ views
@@ -14,7 +14,7 @@
   26K   │ │ ├─┬ meta
   21K   │ │ │ └── lib
   11K   │ │ ├── owner
- 9.9K   │ │ ├── deprecations
+ 9.6K   │ │ ├── deprecations
  7.4K   │ │ ├── metal
  7.0K   │ │ ├── string
  5.1K   │ │ ├── glimmer
@@ -63,7 +63,7 @@
  4.2K   │ ├── deprecated-features
  4.1K   │ ├── template-factory
  4.1K   │ └── version
- 729K   ├── shared-chunks
+ 709K   ├── shared-chunks
  384K   ├─┬ @glimmer
  166K   │ ├── runtime
   60K   │ ├── opcode-compiler

Details

This PR main

Dev

 2.2M └─┬ .
1015K   ├─┬ @ember
 206K   │ ├─┬ -internals
  69K   │ │ ├─┬ views
  64K   │ │ │ └─┬ lib
  23K   │ │ │   ├── mixins
  22K   │ │ │   ├── system
  10K   │ │ │   ├── views
 4.3K   │ │ │   └── compat
  35K   │ │ ├─┬ runtime
  30K   │ │ │ └─┬ lib
  21K   │ │ │   ├── mixins
 5.7K   │ │ │   └── ext
  26K   │ │ ├─┬ meta
  21K   │ │ │ └── lib
  11K   │ │ ├── owner
 9.6K   │ │ ├── deprecations
 7.4K   │ │ ├── metal
 7.0K   │ │ ├── string
 5.1K   │ │ ├── glimmer
 4.9K   │ │ ├── utils
 4.9K   │ │ ├── routing
 4.5K   │ │ ├── error-handling
 4.5K   │ │ ├── utility-types
 4.2K   │ │ ├── container
 4.2K   │ │ ├── browser-environment
 4.1K   │ │ └── environment
 183K   │ ├─┬ routing
  28K   │ │ └── lib
 149K   │ ├─┬ object
  66K   │ │ └─┬ lib
  62K   │ │   └── computed
 114K   │ ├─┬ template-compiler
 109K   │ │ └─┬ lib
  20K   │ │   ├── plugins
 4.6K   │ │   ├── system
 4.1K   │ │   └── -internal
  66K   │ ├─┬ application
 5.6K   │ │ └── lib
  52K   │ ├─┬ debug
  21K   │ │ └── lib
  38K   │ ├─┬ array
 4.9K   │ │ └── lib
  31K   │ ├─┬ engine
 4.7K   │ │ └── lib
  27K   │ ├── runloop
  22K   │ ├─┬ utils
  18K   │ │ └── lib
  20K   │ ├── helper
  11K   │ ├── destroyable
 9.8K   │ ├── instrumentation
 9.4K   │ ├── controller
 7.4K   │ ├── service
 7.2K   │ ├── owner
 6.2K   │ ├── component
 5.6K   │ ├── canary-features
 5.5K   │ ├── modifier
 5.1K   │ ├── template-compilation
 5.0K   │ ├── enumerable
 5.0K   │ ├── test
 4.4K   │ ├── template
 4.4K   │ ├── renderer
 4.2K   │ ├── deprecated-features
 4.1K   │ ├── template-factory
 4.1K   │ └── version
 709K   ├── shared-chunks
 384K   ├─┬ @glimmer
 166K   │ ├── runtime
  60K   │ ├── opcode-compiler
  30K   │ ├── manager
  22K   │ ├── validator
  14K   │ ├── program
  12K   │ ├── reference
  11K   │ ├── destroyable
  10K   │ ├─┬ tracking
 4.4K   │ │ └── primitives
  10K   │ ├── util
 8.1K   │ ├── node
 7.3K   │ ├── global-context
 6.4K   │ ├── wire-format
 5.0K   │ ├── vm
 4.9K   │ ├── encoder
 4.6K   │ ├── owner
 4.1K   │ └── env
  60K   ├─┬ ember-testing
  56K   │ └─┬ lib
  14K   │   ├── test
  14K   │   ├── helpers
  10K   │   ├── ext
 6.5K   │   └── adapters
  31K   ├── backburner.js
  25K   ├── ember
  24K   ├── route-recognizer
  18K   ├─┬ @simple-dom
  14K   │ └── document
 9.2K   ├── dag-map
 4.3K   ├── rsvp
 4.3K   └── router_js

 2.3M └─┬ .
1015K   ├─┬ @ember
 206K   │ ├─┬ -internals
  69K   │ │ ├─┬ views
  64K   │ │ │ └─┬ lib
  23K   │ │ │   ├── mixins
  22K   │ │ │   ├── system
  10K   │ │ │   ├── views
 4.3K   │ │ │   └── compat
  35K   │ │ ├─┬ runtime
  30K   │ │ │ └─┬ lib
  21K   │ │ │   ├── mixins
 5.7K   │ │ │   └── ext
  26K   │ │ ├─┬ meta
  21K   │ │ │ └── lib
  11K   │ │ ├── owner
 9.9K   │ │ ├── deprecations
 7.4K   │ │ ├── metal
 7.0K   │ │ ├── string
 5.1K   │ │ ├── glimmer
 4.9K   │ │ ├── utils
 4.9K   │ │ ├── routing
 4.5K   │ │ ├── error-handling
 4.5K   │ │ ├── utility-types
 4.2K   │ │ ├── container
 4.2K   │ │ ├── browser-environment
 4.1K   │ │ └── environment
 183K   │ ├─┬ routing
  28K   │ │ └── lib
 149K   │ ├─┬ object
  66K   │ │ └─┬ lib
  62K   │ │   └── computed
 114K   │ ├─┬ template-compiler
 109K   │ │ └─┬ lib
  20K   │ │   ├── plugins
 4.6K   │ │   ├── system
 4.1K   │ │   └── -internal
  66K   │ ├─┬ application
 5.6K   │ │ └── lib
  52K   │ ├─┬ debug
  21K   │ │ └── lib
  38K   │ ├─┬ array
 4.9K   │ │ └── lib
  31K   │ ├─┬ engine
 4.7K   │ │ └── lib
  27K   │ ├── runloop
  22K   │ ├─┬ utils
  18K   │ │ └── lib
  20K   │ ├── helper
  11K   │ ├── destroyable
 9.8K   │ ├── instrumentation
 9.4K   │ ├── controller
 7.4K   │ ├── service
 7.2K   │ ├── owner
 6.2K   │ ├── component
 5.6K   │ ├── canary-features
 5.5K   │ ├── modifier
 5.1K   │ ├── template-compilation
 5.0K   │ ├── enumerable
 5.0K   │ ├── test
 4.4K   │ ├── template
 4.4K   │ ├── renderer
 4.2K   │ ├── deprecated-features
 4.1K   │ ├── template-factory
 4.1K   │ └── version
 729K   ├── shared-chunks
 384K   ├─┬ @glimmer
 166K   │ ├── runtime
  60K   │ ├── opcode-compiler
  30K   │ ├── manager
  22K   │ ├── validator
  14K   │ ├── program
  12K   │ ├── reference
  11K   │ ├── destroyable
  10K   │ ├─┬ tracking
 4.4K   │ │ └── primitives
  10K   │ ├── util
 8.1K   │ ├── node
 7.3K   │ ├── global-context
 6.4K   │ ├── wire-format
 5.0K   │ ├── vm
 4.9K   │ ├── encoder
 4.6K   │ ├── owner
 4.1K   │ └── env
  60K   ├─┬ ember-testing
  56K   │ └─┬ lib
  14K   │   ├── test
  14K   │   ├── helpers
  10K   │   ├── ext
 6.5K   │   └── adapters
  31K   ├── backburner.js
  25K   ├── ember
  24K   ├── route-recognizer
  18K   ├─┬ @simple-dom
  14K   │ └── document
 9.2K   ├── dag-map
 4.3K   ├── rsvp
 4.3K   └── router_js

NullVoxPopuli · 2025-03-27T20:26:41Z

In a post-{{action}} modifier world, should we just remove this test?

maybe we just delete the test? it doesn't seem to be doing much. Then we can land this PR! 🎉

tcjr · 2025-03-28T14:37:18Z

@kategengler This one looks ready to go. I removed the node (FastBoot) test that was using an {{action}} modifier.

kategengler · 2025-03-28T15:59:20Z

I've enabled auto-merge, thanks!

tcjr added 2 commits March 22, 2025 09:51

Removed tests targeting DEPRECATE_TEMPLATE_ACTION

57d9d0e

Remove code deprecated via DEPRECATE_TEMPLATE_ACTION

e6ce7f4

kategengler approved these changes Mar 24, 2025

View reviewed changes

Restored non-modifier bits of the action modifier source file

6b2b6f4

kategengler reviewed Mar 25, 2025

View reviewed changes

packages/@ember/-internals/glimmer/lib/resolver.ts Outdated Show resolved Hide resolved

Update packages/@ember/-internals/glimmer/lib/resolver.ts

7bf40dc

kategengler reviewed Mar 25, 2025

View reviewed changes

packages/@ember/-internals/glimmer/lib/resolver.ts Outdated Show resolved Hide resolved

Update packages/@ember/-internals/glimmer/lib/resolver.ts

42172e2

kategengler reviewed Mar 25, 2025

View reviewed changes

packages/@ember/-internals/glimmer/lib/resolver.ts Outdated Show resolved Hide resolved

Update packages/@ember/-internals/glimmer/lib/resolver.ts

0a79d1b

kategengler reviewed Mar 26, 2025

View reviewed changes

packages/@ember/-internals/glimmer/lib/resolver.ts Outdated Show resolved Hide resolved

Update packages/@ember/-internals/glimmer/lib/resolver.ts

8572ca5

Removed node test with action modifier

32da70a

kategengler enabled auto-merge (squash) March 28, 2025 15:59

kategengler merged commit c1c8b00 into emberjs:main Mar 28, 2025
24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[CLEANUP] Remove DEPRECATE_TEMPLATE_ACTION #20882

[CLEANUP] Remove DEPRECATE_TEMPLATE_ACTION #20882

tcjr commented Mar 22, 2025 •

edited

Loading

Uh oh!

tcjr commented Mar 24, 2025

Uh oh!

kategengler commented Mar 24, 2025

Uh oh!

tcjr commented Mar 24, 2025

Uh oh!

NullVoxPopuli commented Mar 24, 2025

Uh oh!

tcjr commented Mar 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 26, 2025 •

edited

Loading

Uh oh!

NullVoxPopuli commented Mar 27, 2025

Uh oh!

tcjr commented Mar 28, 2025

Uh oh!

kategengler commented Mar 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[CLEANUP] Remove DEPRECATE_TEMPLATE_ACTION #20882

[CLEANUP] Remove DEPRECATE_TEMPLATE_ACTION #20882

Conversation

tcjr commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tcjr commented Mar 24, 2025

Uh oh!

kategengler commented Mar 24, 2025

Uh oh!

tcjr commented Mar 24, 2025

Uh oh!

NullVoxPopuli commented Mar 24, 2025

Uh oh!

tcjr commented Mar 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NullVoxPopuli commented Mar 27, 2025

Uh oh!

tcjr commented Mar 28, 2025

Uh oh!

kategengler commented Mar 28, 2025

Uh oh!

Uh oh!

Uh oh!

tcjr commented Mar 22, 2025 •

edited

Loading

github-actions bot commented Mar 26, 2025 •

edited

Loading