Skip to content

Add ability to reflect whitelisted labels #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

valtaroth
Copy link

Following feature request #414 I added the option to have labels mirrored based on two new annotations, <prefix>/reflection-labels and <prefix>/reflection-labels-included.

By default the functionality stays exactly the same with just the content being mirrored. However, once <prefix>/reflection-labels is set to true the source labels will be included in the mirror. <prefix>/reflection-labels-included is a regex list like already used for namespace whitelisting which can be used to finely filter the labels to be mirrored, for example to only mirror labels prefixed with example.com/:

annotations:
  reflector.v1.k8s.emberstack.com/reflection-labels: "true"
  reflector.v1.k8s.emberstack.com/reflection-labels-included: "example\\.com/.*"

Copy link
Contributor

@winromulus winromulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the documentation (README) and rebase on the latest version

@valtaroth
Copy link
Author

Thanks for considering my pull request, I've updated the documentation with my addition and rebased to latest. Please let me know if you require more changes.

@valtaroth
Copy link
Author

I rebased again and integrated my changes with the latest refactoring.

Copy link

github-actions bot commented May 1, 2025

Automatically marked as stale due to no recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 1, 2025
@valtaroth
Copy link
Author

@winromulus was there anything else you need me to do for this PR or has it been rejected?

@winromulus
Copy link
Contributor

hey @valtaroth I'm currently upgrading the repository a bit and then I'll start the review on this again. There is a similar PR with reflecting source annotations and labels, and I also need to consider a feature flag for this to maintain compatibility (basically a merge of the two PRs with a flag). Currently setting up some automation for this and I'll resume reviews after

@valtaroth
Copy link
Author

I understand, thank you for updating me!

@github-actions github-actions bot removed the stale label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants