-
Notifications
You must be signed in to change notification settings - Fork 60
feat: Add range partitioning support #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kitagry
wants to merge
2
commits into
embulk:master
Choose a base branch
from
kitagry:add-range-paritioned
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
in: | ||
type: file | ||
path_prefix: example/example.csv | ||
parser: | ||
type: csv | ||
charset: UTF-8 | ||
newline: CRLF | ||
null_string: 'NULL' | ||
skip_header_lines: 1 | ||
comment_line_marker: '#' | ||
columns: | ||
- {name: date, type: string} | ||
- {name: timestamp, type: timestamp, format: "%Y-%m-%d %H:%M:%S.%N", timezone: "+09:00"} | ||
- {name: "null", type: string} | ||
- {name: long, type: long} | ||
- {name: string, type: string} | ||
- {name: double, type: double} | ||
- {name: boolean, type: boolean} | ||
out: | ||
type: bigquery | ||
mode: replace | ||
auth_method: service_account | ||
json_keyfile: example/your-project-000.json | ||
dataset: your_dataset_name | ||
table: your_field_partitioned_table_name | ||
source_format: NEWLINE_DELIMITED_JSON | ||
compression: NONE | ||
auto_create_dataset: true | ||
auto_create_table: true | ||
schema_file: example/schema.json | ||
range_partitioning: | ||
field: 'long' | ||
range: | ||
start: '90' | ||
end: '100' | ||
interval: '1' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this part use
string
instead ofinteger
? As far as I know, range partition uses a number. And we can check the range is valid (start < end
) if we useinteger
.What do you think of this configuration layout?
(Do we need a
range
block?).(This is just my opinion, I want to ask co-maintainers this comment.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the comment! I followed the api documentation. If you prefer integer, I'll change this!
https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#RangePartitioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it with 49d2c36.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @kitagry. Thank you for waiting.
Could you use this layout? (Sorry, we decided to use the original design (except using
integer
instead ofstring
in range values.)and Could you check the range
start
+interval
<end
?If you have any concern, please let me know.
I referenced the
time_partition
configurations.BigQuery API use
embulk configuration
We discussed this using this design document. (Written in Japanese)
After modification, I'll check the partition feature.