Open
Conversation
r8d8
approved these changes
Jul 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds openalias (https://openalias.org/) support, hidden behind the
openalias-supportfeature gate. This allows associating an address (be it BTC, XMR or ETC) to a domain name, so it is less likely to be hijacked and easier for users to read.When it's enabled, on signing a transaction, it checks if the to address starts with
0x, if not, it will try to parse it as an openalias using the DNS TXT record.An example of ETC's OpenAlias address can be found at
donate.that.world: