Skip to content

Conversation

@kmod-midori
Copy link
Contributor

@kmod-midori kmod-midori commented Nov 11, 2020

This allows primitives in this crate to be used with things like Hmac (I tried to do HMAC-MD5 directly within CNG, but has no success as for now, so opted for this).

@kmod-midori kmod-midori marked this pull request as ready for review January 7, 2021 05:45
@emgre
Copy link
Owner

emgre commented Apr 24, 2023

A few comments that I will address shortly:

  • Migrate to digest 0.10.4
    • A quick glance suggests that it's not that big of a deal to update this PR to 0.10
  • Ideally, I would like the digest_trait module to be private, similarly to how block_cipher_trait was done.
    • For a first pass, we could skip the Fixed[...] traits and only implement the basic digest traits directly on Hash
    • On a second pass, we could add hard types for each hashing algorithm and implement the Fixed[...] traits
  • We should also provide the MAC algorithms through the digest library.

@emgre
Copy link
Owner

emgre commented Apr 27, 2023

This will be done after the 0.5 release.

@emgre emgre changed the base branch from master to main September 1, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants