perf: remove redundant clone in about.rs demo#8057
Open
EtherealPsyche wants to merge 1 commit intoemilk:mainfrom
Open
perf: remove redundant clone in about.rs demo#8057EtherealPsyche wants to merge 1 commit intoemilk:mainfrom
EtherealPsyche wants to merge 1 commit intoemilk:mainfrom
Conversation
|
Preview is being built... Preview will be available at https://egui-pr-preview.github.io/pr/8057-main View snapshot changes at kitdiff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As shown in the commit, this is exactly what it contains. There was a redundant and seemingly meaningless
.clone()inabout.rs, which I removed. Was it because the function signature ofImage::new()was different in older versions of egui?