Skip to content

Add EM_JS_MACROS #24272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add EM_JS_MACROS #24272

wants to merge 1 commit into from

Conversation

hoodmane
Copy link
Collaborator

@hoodmane hoodmane commented May 6, 2025 •
edited
Loading

  • Add a test

@hoodmane hoodmane mentioned this pull request May 6, 2025
Merged
sbc100
sbc100 reviewed May 6, 2025
View reviewed changes
system/include/emscripten/em_js.h
@@ -73,6 +73,9 @@
#define EM_ASYNC_JS(ret, name, params, ...) _EM_JS(ret, name, __asyncjs__##name, params, \
"{ return Asyncify.handleAsync(async () => " #__VA_ARGS__ "); }")

// Macros enabled version of EM_JS. Requires an extra layer of indirection.
#define EM_JS_MACROS(ret, func_name, args, body...) \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can come up with better name? EM_JS_WITH_MACROS ? EM_JS_PREPROCESSED ? I don't really love them either :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoodmane @sbc100