[WIP] [esm-integration] Add a new core test mode and either fix or disable all tests #24288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all test. This is fairly larger change which can likely to split up before landing.
sbc100
changed the title
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 9, 2025
This change also adds a new core test mode for ESM integration and uses this to run all the variants of test_fs_js_api. As part of this I also updated the octal constants in test_fs_js_api.c which are required to be of the new form in strict JS. All code in ES modules is implicitly in strict mode. Split out from emscripten-core#24288 See emscripten-core#24060
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 9, 2025
This change also adds a new core test mode for ESM integration and uses this to run all the variants of test_fs_js_api. As part of this I also updated the octal constants in test_fs_js_api.c which are required to be of the new form in strict JS. All code in ES modules is implicitly in strict mode. Split out from emscripten-core#24288 See emscripten-core#24060
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 9, 2025
This change also adds a new core test mode for ESM integration and uses this to run all the variants of test_fs_js_api. As part of this I also updated the octal constants in test_fs_js_api.c which are required to be of the new form in strict JS. All code in ES modules is implicitly in strict mode. Split out from emscripten-core#24288 See emscripten-core#24060
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 9, 2025
This change also adds a new core test mode for ESM integration and uses this to run all the variants of test_fs_js_api. As part of this I also updated the octal constants in test_fs_js_api.c which are required to be of the new form in strict JS. All code in ES modules is implicitly in strict mode. Split out from emscripten-core#24288 See emscripten-core#24060
sbc100
added a commit
that referenced
this pull request
May 9, 2025
This change also adds a new core test mode for ESM integration and uses this to run all the variants of test_fs_js_api. As part of this I also updated the octal constants in test_fs_js_api.c which are required to be of the new form in strict JS. All code in ES modules is implicitly in strict mode. Split out from #24288 See #24060
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 13, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 13, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 13, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 13, 2025
sbc100
added a commit
that referenced
this pull request
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fairly larger change which can likely to split up before landing.