Skip to content

[MODULARIZE=instance] Mark ABORT_ON_WASM_EXCEPTIONS is not supported. NFC #24331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

[MODULARIZE=instance] Mark ABORT_ON_WASM_EXCEPTIONS is not supported. NFC #24331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion site/source/docs/compiling/Modularized-Output.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ fix in future releses. Current limitations include:
object does not work. This is because symbols are exported directly using
ES6 module syntax rathar than using a global `Module` object.

* `ccall`/`cwrap`, these depend on the internal `Module` object.
* `ccall`/`cwrap` are not supported (these depend on the internal `Module`
object).

* :ref:`abort_on_wasm_exceptions` is not supported (requires wrapping wasm
exports).


Source Phase Imports (experimental)
Expand Down
1 change: 1 addition & 0 deletions test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9460,6 +9460,7 @@ def test_emscripten_stack(self):
self.do_core_test('test_stack_get_free.c')

# Tests settings.ABORT_ON_WASM_EXCEPTIONS
@no_modularize_instance('ABORT_ON_WASM_EXCEPTIONS')
def test_abort_on_exceptions(self):
self.set_setting('ABORT_ON_WASM_EXCEPTIONS')
self.set_setting('ALLOW_TABLE_GROWTH')
Expand Down
6 changes: 4 additions & 2 deletions tools/link.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,9 +810,11 @@ def limit_incoming_module_api():
default_setting('INCOMING_MODULE_JS_API', [])

if settings.MODULARIZE == 'instance':
diagnostics.warning('experimental', '-sMODULARIZE=instance is still experimental. Many features may not work or will change.')
diagnostics.warning('experimental', 'MODULARIZE=instance is still experimental. Many features may not work or will change.')
if options.oformat != OFormat.MJS:
exit_with_error('MODULARIZE instance is only compatible with ES module output format')
exit_with_error('MODULARIZE=instance is only compatible with ES module output format')
if settings.ABORT_ON_WASM_EXCEPTIONS:
exit_with_error('MODULARIZE=instance is only compatible with ABORT_ON_WASM_EXCEPTIONS')
if 'INCOMING_MODULE_JS_API' in user_settings:
for s in ['wasmMemory', 'INITIAL_MEMORY']:
if s in settings.INCOMING_MODULE_JS_API:
Expand Down