Build and push multi-platform docker image#1567
Merged
Merged
Conversation
Collaborator
|
Nice! Thanks for working on this. |
|
Any chance this will be merged? |
sbc100
reviewed
Sep 24, 2025
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Sorry, I had some old comments that never code sent.
radiantly
force-pushed
the
multiplatform
branch
from
3d25176 to
e24965b
Compare
sbc100
approved these changes
Sep 25, 2025
mmorel-35
pushed a commit
to mmorel-35/emsdk
that referenced
this pull request
Feb 3, 2026
This PR adds the `publish-docker-image-multiplatform` CI job step that pushes a multi-platform docker image when a new tag is created. emscripten-core#1211 Unfortunately, this is not as simple as pushing two images targeting different platforms to the same tag. There are a couple of ways to create a multi-platform image: - Using `docker buildx` to build images for all platforms. To do this images targeting non-native platforms would need to be built using QEMU (slower), a remote machine or cross-compilation. - Building and publishing platform-specific images `emscripten/emsdk-x64`, `emscripten/emsdk-arm64` and then creating a manifest that links to these images. This is the simpler solution to implement, and is what this PR does. Tested with CircleCI on my fork. See the pushed images at [radiantly/emsdk · DockerHub](https://hub.docker.com/r/radiantly/emsdk/tags)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
publish-docker-image-multiplatformCI job step that pushes a multi-platform docker image when a new tag is created. #1211Unfortunately, this is not as simple as pushing two images targeting different platforms to the same tag. There are a couple of ways to create a multi-platform image:
docker buildxto build images for all platforms. To do this images targeting non-native platforms would need to be built using QEMU (slower), a remote machine or cross-compilation.emscripten/emsdk-x64,emscripten/emsdk-arm64and then creating a manifest that links to these images. This is the simpler solution to implement, and is what this PR does.Tested with CircleCI on my fork. See the pushed images at radiantly/emsdk · DockerHub