-
-
Notifications
You must be signed in to change notification settings - Fork 25
406 home page redesign #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
👷 Deploy request for cool-creponne-3e1272 pending review.Visit the deploys page to approve it
|
At the moment, I am building this section. My question addresses an issue where the page displays only 4 item images instead of the 5 latest ones as required. The current Supabase settings limit the number of fetched items to 4. This was due to the previous functionality, but the problem arises when items are reserved or given away; they are not displayed, which should be changed.
To resolve this, the following updates are needed:
The updated SQL for the fetch_recently_added_items function:
We have two options:
I'll ask the UI/UX designers if it is essential to have 5 cards on the screen. |
we need change the query limitation to 5 and add logic to exclude items that are either reserved or given away.
Hey @OlenaReukova I think your solution looks really sensible. I don't really see a need to push back on the design, this is just a database query and should be very easily swapped for any new format we need. I'd say just go ahead a create a new migration file with the updated script you've written and our automated workflows will take care it :) |
@camelPhonso I’ve been a little busy recently, so I didn’t have the opportunity to continue working on the ticket. Thank you for your comment — I’ve now taken it into account and will continue from there. 😊 |
Checklist:
Description
**Relates #406 and #405 OR Closes #406 and #405 **
Include here a short description of what behaviour this Pull Request introduces.
Outline any new dependencies introduced.
Files changed
Include one to two lines on the necessary changes to each file.
UI changes
If this PR includes changes to the UI include a screengrab of the alterations in review.
Changes to Documentation
Include an outline of why Documentation needed to be updated with this PR
Tests
Include a description of any tests added - if none have been added explain why.