Add marqueeOn prop to MarqueeController#2833
Open
Djspaceg wants to merge 2 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2833 +/- ##
==========================================
Coverage ? 44.75%
==========================================
Files ? 163
Lines ? 8244
Branches ? 2013
==========================================
Hits ? 3690
Misses ? 3424
Partials ? 1130
Continue to review full report at Codecov.
|
added 2 commits
July 30, 2020 10:28
Enact-DCO-1.0-Signed-off-by: Blake Stephens <blake.stephens@lge.com>
Enact-DCO-1.0-Signed-off-by: Blake Stephens <blake.stephens@lge.com>
e2f0e9b to
19f8a15
Compare
|
Blake Stephens seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
I have read and understand the contribution guide
A CHANGELOG entry is included
At least one test case is included for this feature or bug fix
Documentation was added or is not needed
This is an API breaking change
Issue Resolved / Feature Added
It's not currently possible to set the
marqueeOnprop on a container, which then informs all of the children marquees.Resolution
This adds support to
MarqueeControllerto support settingmarqueeOnon the controller and having all of the children respond, unless they'd been given explicit instructions of their own.Additional Considerations
This branch is 6 months old. I figured I might as well open a PR.