WRO-478: POC for item reordering in VirtualList#3076
Draft
SkylerBaek wants to merge 1 commit intodevelopfrom
Draft
WRO-478: POC for item reordering in VirtualList#3076SkylerBaek wants to merge 1 commit intodevelopfrom
SkylerBaek wants to merge 1 commit intodevelopfrom
Conversation
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Codecov Report
@@ Coverage Diff @@
## develop #3076 +/- ##
========================================
Coverage 48.10% 48.10%
========================================
Files 171 171
Lines 9717 9717
Branches 2609 2609
========================================
Hits 4674 4674
Misses 3956 3956
Partials 1087 1087 Continue to review full report at Codecov.
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
POC for item reordering in VirtualList
Resolution
The former POC implementation of #3027 is totally refined.
editableprop rather than several individual propsAdditional Considerations
There are so many bugs and missing behaviors.
Links
WRO-478 (companion enactjs/sandstone#1293)
WRN-17866 (#3027)
Comments
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)