WRQ-3732: Notify focus moving by key from pointer mode internally#3191
Draft
SkylerBaek wants to merge 1 commit intodevelopfrom
Draft
WRQ-3732: Notify focus moving by key from pointer mode internally#3191SkylerBaek wants to merge 1 commit intodevelopfrom
SkylerBaek wants to merge 1 commit intodevelopfrom
Conversation
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3191 +/- ##
===========================================
- Coverage 82.22% 82.16% -0.06%
===========================================
Files 155 155
Lines 7149 7154 +5
Branches 1885 1885
===========================================
Hits 5878 5878
- Misses 998 1003 +5
Partials 273 273 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
When focus is entering to or leaving from a container by 5-way key input on 5-way mode, Spotlight notify this situation internally so that related features works properly. But there is no notification on pointer mode at the same situation.
Resolution
Update internal logic to notify the situation on pointer mode just like on 5-way mode.
Additional Considerations
Links
WRQ-3732
Comments