Skip to content

WRQ-3732: Notify focus moving by key from pointer mode internally#3191

Draft
SkylerBaek wants to merge 1 commit into
developfrom
feature/WRQ-3732_approach_1
Draft

WRQ-3732: Notify focus moving by key from pointer mode internally#3191
SkylerBaek wants to merge 1 commit into
developfrom
feature/WRQ-3732_approach_1

Conversation

@SkylerBaek

Copy link
Copy Markdown
Member

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

When focus is entering to or leaving from a container by 5-way key input on 5-way mode, Spotlight notify this situation internally so that related features works properly. But there is no notification on pointer mode at the same situation.

Resolution

Update internal logic to notify the situation on pointer mode just like on 5-way mode.

Additional Considerations

Links

WRQ-3732

Comments

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
@codecov

codecov Bot commented Nov 30, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.16%. Comparing base (6becfeb) to head (4533dbe).
⚠️ Report is 281 commits behind head on develop.

Files with missing lines Patch % Lines
packages/spotlight/src/spotlight.js 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3191      +/-   ##
===========================================
- Coverage    82.22%   82.16%   -0.06%     
===========================================
  Files          155      155              
  Lines         7149     7154       +5     
  Branches      1885     1885              
===========================================
  Hits          5878     5878              
- Misses         998     1003       +5     
  Partials       273      273              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant