Add pyupgrade to pre-commit hooks

[ulgens]

Description

Inspired from @browniebroke 's PR We can and we should automate this type of checks. pyupgrade is a great tool to do that and we already had pre-commit setup in place.

I tried to minimize the changes by excluding %s to f-string conversions but it looks like the code was a bit neglected so the resulting changes are still not so small.

This looks like nitpicking and "churn", but in my experience, pyupgrade and django-upgrade helps a lot to minimize the maintenance efforts.

[browniebroke]

Yes, I considered adding pyupgrade to do my previous PR, but consciously chose not to as I thought it would introduce more churn than what I was aiming for, but to be honest I was expecting a bigger diff than that. I assume that disabling percent-formt to f-string is helping a lot.

... in my experience, pyupgrade and django-upgrade helps a lot to minimize the maintenance efforts

It could indeed help us cleanup old branches from #9681 as the project drops support for old versions, so might pay off in the long run

[ulgens]

@browniebroke Removing the --keep-percent-format arg creates an additional diff of 24 files changed, 43 insertions(+), 43 deletions(-); which I still think it's not that big but feels more churn-y. Having all changes handled in a single commit is another option.

I wanted to go with minimal changes to be safer but we can use it without excluding any rules.

[browniebroke]

I wanted to go with minimal changes to be safer but we can use it without excluding any rules.

Yes I agree, that makes sense to keep changes to a minimum 👍

[auvipy]

looks good

[Copilot]

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.