eos-write-live-image: Get boot.zip etc from inside ISO#744
Draft
eos-write-live-image: Get boot.zip etc from inside ISO#744
Conversation
In 7b48fb6 "eos-write-live-image: Use squashfs image from ISOs" we taught this tool to copy the 'endless.squash' file and its signature from within an .iso. However we still required the .boot.zip, .boot.zip.asc and .img.asc files to be alongside the .iso file. These files can be found within the .iso, and with a relatively small change we can use them directly.
Member
Author
|
Draft because while I have tested that the script succeeds when given an ISO, the result (on a loopback FS) doesn't boot on my manually-constructed QEMU invocation; and I have not tested the non-ISO case. |
jprvita
approved these changes
Apr 26, 2022
Contributor
jprvita
left a comment
jprvita
left a comment
There was a problem hiding this comment.
This LGTM, but yes, let's make sure all different paths are tested and the result boots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 7b48fb6 "eos-write-live-image: Use
squashfs image from ISOs" we taught this tool to copy the
'endless.squash' file and its signature from within an .iso. However we
still required the .boot.zip, .boot.zip.asc and .img.asc files to be
alongside the .iso file.
These files can be found within the .iso, and with a relatively small
change we can use them directly.