icon-grid: Simplify installing JSON files #256
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keys in arch-blacklist.json are the autotools $(host_cpu) variable. The only key in that file is "arm". But nowadays we only support 64-bit ARM, for which $(host_cpu) is "aarch64". So this filter now does nothing. It doesn't matter, anyway, because the app grid code in Endless OS 3.9 and later just hides empty folders. Remove the blacklist logic, which also removes some problematic terminology from our distro.
- All Python dicts are now order-preserving. - makedirs() has an exist_ok argument. - argparse.FileType has actually been around for a long time.
Since removing the arch blocklist we don't actually make any changes to the contents of these files. So, rename them from *.json.in to *.json and rewrite write-grid-json.py as validate-grid-json.py, calling it as a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since removing the arch blocklist we don't actually make any changes to
the contents of these files. So, rename them from *.json.in to *.json
and rewrite write-grid-json.py as validate-grid-json.py, calling it as a
test.
This builds on #255 and is even less well tested.