Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-product] Add Motorola Mobility product page. #4328

Merged
merged 7 commits into from
Jan 13, 2024

Conversation

ab
Copy link
Contributor

@ab ab commented Dec 19, 2023

I parsed these from the JSON/HTML blob embedded in the Motorola website.

Source data: https://en-us.support.motorola.com/app/software-security-update

If they change the website format, then this will be difficult to update, but at least I figure this is a ton of useful info for all their current product lines.

Parsing script (wasn't sure if there was someplace in the repo for this):
https://gist.github.com/ab/67c6343530c6b8e599f07cedccbcba3d

Copy link

welcome bot commented Dec 19, 2023

Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals.

It's not clear that this provides any value. The Motorola website has
contradictory info, saying for example that "moto g pure" currently
receives regular updates, even though they also say that security
updates for that device will stop in September 2023 (two months ago).
@ab ab marked this pull request as ready for review December 19, 2023 20:18
The footer already has a link to the Motorola site.
@ab ab changed the title Add Motorola Mobility product page. [new-product] Add Motorola Mobility product page. Dec 19, 2023
@BiNZGi BiNZGi added the new-product This PR adds a new product to the website. label Dec 22, 2023
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ab, thanks a lot for this contribution. Here are my comments and suggestions.

I did not check the data as this was generated by https://gist.github.com/ab/67c6343530c6b8e599f07cedccbcba3d.

products/motorola.md Outdated Show resolved Hide resolved
products/motorola.md Outdated Show resolved Hide resolved
products/motorola.md Outdated Show resolved Hide resolved
products/motorola.md Outdated Show resolved Hide resolved
products/motorola.md Outdated Show resolved Hide resolved
products/motorola.md Outdated Show resolved Hide resolved
products/motorola.md Outdated Show resolved Hide resolved
products/motorola.md Outdated Show resolved Hide resolved
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after a few minor adjustments.

products/motorola-mobility.md Outdated Show resolved Hide resolved
products/motorola-mobility.md Outdated Show resolved Hide resolved
products/motorola-mobility.md Outdated Show resolved Hide resolved
@marcwrobel marcwrobel merged commit 96ebc88 into endoflife-date:master Jan 13, 2024
5 checks passed
Copy link

welcome bot commented Jan 13, 2024

Thank you and congratulations for your first contribution! endoflife.date is a community wiki, and we're always looking for more contributions 🥇 💯 🎉.

@marcwrobel
Copy link
Member

Thanks a lot for this contribution @ab ! The page is now online: https://endoflife.date/motorola-mobility. I also created an issue for the automation part on endoflife-date/release-data#277.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants