Conversation
Signed-off-by: David Sooter <david.sooter@cpars.de>
04a2a28 to
1c49b6a
Compare
Signed-off-by: David Sooter <david.sooter@cpars.de>
Signed-off-by: David Sooter <david.sooter@cpars.de>
Signed-off-by: David Sooter <david.sooter@cpars.de>
196d409 to
d6c7084
Compare
|
Add pd support and access via config |
|
add binaries |
|
Hi @d-sooter ... WOW! I didn't see this coming. Thank you for your interest in this project and willingness to contribute to it. However, to be honest, this is quite a big PR that you have submitted and it is not going to be easy or straightforward to review it and merge it into the codebase. Maybe you may have missed reading up the contribution guidelines first. For something this big, I would have preferred to discuss about it first so that the PR process would have been smoother. I haven't looked at all your changes, but at a glance, there are a lot of changes across many areas which is going to make it a challenge for me to review it in a timely and efficient manner. I hope you understand, FlashPipe is a stable solution that is widely used and a PR this big is difficult for me to verify that it has not broken any of the existing parts. I'll need some time to look through what you did and think about how we can proceed. In the meantime, I think it's also worth it that you read up the contribution guidelines and reconsider if you can break it up into smaller independent PRs to simplify the submission process. |
|
Hi there. I originally forked it because we needed a few other features and you already done such great work on this. I actually handnt planned to create the pr it sort of just happened :-) I would be happy to discuss it with you and break it up into parts. The main areas i made changes on are
Like i said lots of this is what we needed for our usecase and might not be right for everyone. Buuut if there are parts that make sense we can talk about breaking them down and consolidating them. I can the break the features down into smaller prs. Cheers |
No description provided.