Add network and feature flags to GetNodeInfoResponse#1
Closed
enigbe wants to merge 5 commits into
Closed
Conversation
enigbe
force-pushed
the
2026-02-add-network-and-node-features-to-node-info
branch
from
5bd859e to
b873ddd
Compare
enigbe
force-pushed
the
2026-02-add-network-and-node-features-to-node-info
branch
2 times, most recently
from
b775f65 to
f43b8f8
Compare
enigbe
force-pushed
the
2026-02-add-network-and-node-features-to-node-info
branch
from
f43b8f8 to
464321b
Compare
- Update ldk-node to a newer revision and adapt ldk-server to the changed payment event surface. PaymentForwarded now preserves the full prev_htlcs and next_htlcs vectors in the gRPC model. - Remove the Bolt11Jit payment kind as a breaking API change. JIT BOLT 11 payments are now represented as regular Bolt11 payments with counterparty_skimmed_fee_msat set when applicable. - Regenerate protobuf bindings and drop the obsolete Bolt11Jit serde attribute. AI-Assisted-By: OpenAI Codex
LDK may render invoice and offer descriptions through safe display wrappers before CLI output sanitization sees them. In that case, bidi controls are replaced instead of escaped as \uXXXX. Update the tests to check the behavior that matters: decoded CLI output must not contain raw bidi override characters.
Build the test TLS server config with rustls's ring provider explicitly instead of relying on process-global provider auto-detection. This avoids panics when rustls cannot infer a single CryptoProvider from the compiled feature set.
Bump ldk-node dependency to `00dba456a10cb60172eaa74e0a8b11c5e0473dcc`
We return the node-announcement feature set from GetNodeInfoResponse so clients can inspect advertised node capabilities, such as keysend support, directly from the node info API. For now, only features advertised in node_announcement are populated. We document this narrower contract explicitly while leaving the Features message shape open for future parity with APIs such as cln-grpc, where the default feature set may also include init, channel, and invoice features. AI-Assisted-By: OpenAI Codex
enigbe
force-pushed
the
2026-02-add-network-and-node-features-to-node-info
branch
from
464321b to
4222171
Compare
Owner
Author
|
Closing this after opening PR on main repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
To run simulations of payment activity against a network with
ldk-node/server,sim-lnrequires knowledge of the nodes network and whether it supportskeysend. These data points are not readily available on the library (node) and the daemon (server). This PR, in conjunction with exposed APIs in lightningdevkit/ldk-node#810, adds a new field:featuresto theGetNodeInfoResponse. We try to maintain parity with similar node info responses as doeslnrpcandcln-grpc.