Add modulefiles-mode for Emacs users#577
Closed
Laurent-Besson wants to merge 0 commit intoenvmodules:mainfrom
Closed
Add modulefiles-mode for Emacs users#577Laurent-Besson wants to merge 0 commit intoenvmodules:mainfrom
Laurent-Besson wants to merge 0 commit intoenvmodules:mainfrom
Conversation
xdelaruelle
requested changes
Jun 13, 2025
Collaborator
xdelaruelle
left a comment
xdelaruelle
left a comment
There was a problem hiding this comment.
THanks a lot for this contribution. This is great addition to the project. Here are some changes to address
share/emacs/modulefiles-mode.el
Outdated
| ;; Maintainer: Laurent Besson <laurent.42.besson@gmail.com> | ||
| ;; Created: June 12, 2025 | ||
| ;; Version: 1.0 | ||
| ;; Package-Requires: ((emacs "24") |
Collaborator
There was a problem hiding this comment.
do you confirm that emacs 24 is the oldest version that could run such mode file?
Collaborator
|
Please also sign off your commit to approve the developer certificate of origin: https://modules.readthedocs.io/en/latest/CONTRIBUTING.html#developer-certificate-of-origin Thanks |
Collaborator
|
@Laurent-Besson Many thanks for the changes, I will handle the rest from now. |
Collaborator
|
I made a bad move with git that broke this pull request. Anyway the changes will be merged. Thanks again for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is based on tcl-mode and add colorization for Modules commands