Skip to content

chore: fixes grammar on 404 #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2025
Merged

chore: fixes grammar on 404 #1413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d6890f
chore: fixes grammar on 404
mathetake Oct 22, 2025
ff42908
more
mathetake Oct 22, 2025
1e47646
Merge branch 'main' into grammeron404
mathetake Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cmd/aigw/testdata/translate_basic.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,7 @@ metadata:
spec:
directResponse:
body:
inline: No matching route found. It is likely that the model specified your
request is not configured in the Gateway.
inline: No matching route found. It is likely because the model specified in your request is not configured in the Gateway.
type: null
statusCode: 404
---
Expand Down
2 changes: 1 addition & 1 deletion internal/controller/ai_gateway_route.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ func generateHTTPRouteFilters(aiGatewayRoute *aigv1a1.AIGatewayRoute) []*egv1a1.
Body: &egv1a1.CustomResponseBody{
Inline: ptr.To(
// "Likely" since the matching rule can be arbitrary, not necessarily matching on the model name.
`No matching route found. It is likely that the model specified your request is not configured in the Gateway.`,
`No matching route found. It is likely because the model specified in your request is not configured in the Gateway.`,
),
},
},
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/testupstream_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func TestWithTestUpstream(t *testing.T) {
name: "openai",
modelName: "non-existent-model",
expStatus: 404,
expResponseBody: `No matching route found. It is likely that the model specified your request is not configured in the Gateway.`,
expResponseBody: `No matching route found. It is likely because the model specified in your request is not configured in the Gateway.`,
},
{
name: "openai-header-mutation",
Expand Down
Loading