-
Notifications
You must be signed in to change notification settings - Fork 219
add http server test #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add http server test #134
Conversation
Signed-off-by: helight <[email protected]>
7e65013 to
2831af1
Compare
|
@lizan please help to review this pr |
lizan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have some sort of test for this config? Like verify examples in envoy repo.
| typed_config: | ||
| "@type": type.googleapis.com/sample.Decoder | ||
| key: via | ||
| key: Via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: keep this lowercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just for testing this function
http_filter.cc
const LowerCaseString HttpSampleDecoderFilter::headerKey() const {
return LowerCaseString(config_->key());
}
Ok |
Signed-off-by: helight <[email protected]>
4d6287a to
23a01a4
Compare
@lizan I add a startup.sh and verify.sh, please help to check |
Uh oh!
There was an error while loading. Please reload this page.