server: support bootstrap YAML include/glob#43973
Open
garimauttam wants to merge 3 commits intoenvoyproxy:mainfrom
Open
server: support bootstrap YAML include/glob#43973garimauttam wants to merge 3 commits intoenvoyproxy:mainfrom
garimauttam wants to merge 3 commits intoenvoyproxy:mainfrom
Conversation
When --config-path is a directory, load and merge YAML files in lexical order. Signed-off-by: garima-uttam <garimauttam@ibm.com>
Allow a top-level "include" key in YAML bootstrap files to pull in other YAML fragments (file/dir/glob), with recursive expansion and cycle detection. Signed-off-by: garima-uttam <garimauttam@ibm.com>
Contributor
|
CI failures look relevant. |
stekole
reviewed
Mar 18, 2026
| } | ||
|
|
||
| absl::StatusOr<std::vector<std::string>> | ||
| expandIncludePath(const std::string& include_path, const std::string& including_file_path, |
Contributor
There was a problem hiding this comment.
expandIncludePath resolves includes to absolute paths but never validates they're within a safe base directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements top-level YAML
includesupport for bootstrap configs.includeto reference a file, directory, or wildcard pattern (e.g.conf.d/*.yaml), with recursive expansion.--config-pathhelp text and adds focused coverage intest/server/bootstrap_config_dir_test.cc.Fixes #43511.