Limit source files to one logger ID#43980
Open
etruong42 wants to merge 2 commits intoenvoyproxy:mainfrom
Open
Conversation
etruong42
requested review from
botengyao,
danzh2010,
ggreenway,
kyessenov,
mattklein123,
nezdolik,
tonya11en,
tyxia,
wbpcode,
yanavlasov and
zuercher
as code owners
etruong42
force-pushed
the
ulid
branch
2 times, most recently
from
b50e39d to
559eb7e
Compare
Split source files such that each source file has at most one logger ID This will allow the definition of fine grain logging groups such that each group can map to a logger ID, since fine grain logging is based on source file paths. Signed-off-by: Ethan Truong <ethantruong@google.com>
Signed-off-by: Ethan Truong <ethantruong@google.com>
Contributor
Author
|
/assign-from @envoyproxy/first-pass-reviewers |
|
@envoyproxy/first-pass-reviewers assignee is @yanjunxiang-google |
Contributor
|
/assign @botengyao |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split source files such that each source file has at most one logger ID
This will allow the definition of fine grain logging groups such that each group can map to a logger ID, since fine grain logging is based on source file paths.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]