upstream: Uses a more efficient type for ClusterMap#44006
Open
birenroy wants to merge 4 commits intoenvoyproxy:mainfrom
Open
upstream: Uses a more efficient type for ClusterMap#44006birenroy wants to merge 4 commits intoenvoyproxy:mainfrom
birenroy wants to merge 4 commits intoenvoyproxy:mainfrom
Conversation
…-efficient. Signed-off-by: Biren Roy <birenroy@google.com>
Signed-off-by: Biren Roy <birenroy@google.com>
Contributor
Author
|
/assign @adisuissa |
Contributor
Author
|
/assign @paul-r-gall |
Signed-off-by: Biren Roy <birenroy@google.com>
Signed-off-by: Biren Roy <birenroy@google.com>
Contributor
Author
|
I'm having a hard time understanding why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces
std::mapwithabsl::flat_hash_map, which is much more efficient in terms of memory allocations and CPU/memory operations per lookup.In the one case where the ordering matters, the
ClusterMapdata is sorted before dumping.Commit Message: upstream: Uses a more efficient type for ClusterMap
Additional Description:
Risk Level:
Testing: ran unit and integration tests locally
Docs Changes:
Release Notes:
Platform Specific Features: