Add support for substitution formatters in all HttpService uses#44007
Open
Retr0-XD wants to merge 1 commit intoenvoyproxy:mainfrom
Open
Add support for substitution formatters in all HttpService uses#44007Retr0-XD wants to merge 1 commit intoenvoyproxy:mainfrom
Retr0-XD wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
|
Hi @Retr0-XD, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Member
|
This requires #43803 to merge first. /wait |
Contributor
|
Repo policy requires disclosure the use of AI tools. Can you update the description to conform to repo template? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds substitution formatter support to
equest_headers_to_add for HTTP service-based integrations that previously treated header values as static strings.
It introduces a shared helper, HttpServiceHeadersApplicator, and wires it into:
As a result, configured headers can use formatter expressions and are evaluated at apply-time rather than only at construction-time.
Motivation
Some HTTP service configurations need dynamic header values. Existing code paths in these integrations only copied raw string values and did not support formatter evaluation.
What changed
Behavior
Testing
equest_headers_to_add and checking resolved outbound headers.