vhds: refactor tests that use vhds so they can use static-routes later#44008
Open
adisuissa wants to merge 1 commit intoenvoyproxy:mainfrom
Open
vhds: refactor tests that use vhds so they can use static-routes later#44008adisuissa wants to merge 1 commit intoenvoyproxy:mainfrom
adisuissa wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: vhds: refactor tests that use vhds so they can use static-routes later
Additional Description:
Currently VHDS can only be used for dynamic routes (fetched over RDS).
This PR refactors the integration tests so they can test both dynamic-routes (RDS) and static-routes.
The static-route validation is not yet enabled (parameterized test is constrained to RDS only), because the code-base currently doesn't support VHDS in a static-route. This will be enabled in the future.
Risk Level: low - tests only
Testing: Updated the tests, did not add any new test.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A