Open
Conversation
Signed-off-by: Yilin Guo <guoyilin@google.com>
guoyilin42
requested review from
botengyao,
tyxia and
yanavlasov
as code owners
Contributor
Author
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for the tools/list method in the MCP JSON REST Bridge filter, enhancing its functionality to discover available tools. Key improvements include robust handling of Content-Length and Transfer-Encoding headers to prevent HTTP request smuggling vulnerabilities, and better error responses for Method Not Allowed by including an Allow header. The changes are well-covered by new unit and integration tests, ensuring the stability and correctness of the new features and fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: mcp: add tools/list support.
Additional Description: N/A
Risk Level: Low
Testing: Unit and Integ test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]