Skip to content

stats: refactor forEachHostMetric to avoid using clusters()#44015

Draft
adisuissa wants to merge 1 commit intoenvoyproxy:mainfrom
adisuissa:for_each_metric_get_active_clusters
Draft

stats: refactor forEachHostMetric to avoid using clusters()#44015
adisuissa wants to merge 1 commit intoenvoyproxy:mainfrom
adisuissa:for_each_metric_get_active_clusters

Conversation

@adisuissa
Copy link
Contributor

Commit Message: stats: refactor forEachHostMetric to avoid using clusters()
Additional Description:
Currently the forEachHostMetric method invokes clusters which creates a temporary map with all the active and warming clusters, and then the forEachHostMetric method iterates over all the active clusters.
This PR introduces the forEachActiveCluster iterator in the Cluster-Manager that instead of creating the temporary map, allows forEachHostMetric to directly iterate over the active clusters and collect the stats.

Risk Level: low - an internal refactor
Testing: Updated the mocks to support the new iterator.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #44015 was opened by adisuissa.

see: more, trace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant