stats: refactor forEachHostMetric to avoid using clusters()#44015
Draft
adisuissa wants to merge 1 commit intoenvoyproxy:mainfrom
Draft
stats: refactor forEachHostMetric to avoid using clusters()#44015adisuissa wants to merge 1 commit intoenvoyproxy:mainfrom
adisuissa wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: stats: refactor forEachHostMetric to avoid using clusters()
Additional Description:
Currently the forEachHostMetric method invokes clusters which creates a temporary map with all the active and warming clusters, and then the
forEachHostMetricmethod iterates over all the active clusters.This PR introduces the
forEachActiveClusteriterator in the Cluster-Manager that instead of creating the temporary map, allowsforEachHostMetricto directly iterate over the active clusters and collect the stats.Risk Level: low - an internal refactor
Testing: Updated the mocks to support the new iterator.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A