-
Notifications
You must be signed in to change notification settings - Fork 578
feat(securitypolicy): Update GatewayAPI to support tcp security policy #7171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(securitypolicy): Update GatewayAPI to support tcp security policy #7171
Conversation
…king down larger pr's in to smaller ones Signed-off-by: davem-git <[email protected]>
… Breaking down larger pr's in to smaller ones Signed-off-by: davem-git <[email protected]>
…curity-policy-gateway-api
…curity-policy-api
…s clientIP and what defines a clientIP Signed-off-by: davem-git <[email protected]>
…ateway into feat-tcp-security-policy-api
…curity-policy-gateway-api
Signed-off-by: davem-git <[email protected]>
…curity-policy-gateway-api
Signed-off-by: davem-git <[email protected]>
…ateway into feat-tcp-security-policy-api
Signed-off-by: davem-git <[email protected]>
Signed-off-by: davem-git <[email protected]>
Signed-off-by: davem-git <[email protected]>
…curity-policy-gateway-api
…ty security policies, but that was determined as fine so the check to block it was removed Signed-off-by: davem-git <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7171 +/- ##
==========================================
+ Coverage 71.04% 71.08% +0.03%
==========================================
Files 229 229
Lines 41099 41164 +65
==========================================
+ Hits 29198 29260 +62
- Misses 10181 10184 +3
Partials 1720 1720 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: davem-git <[email protected]>
…curity-policy-gateway-api
Signed-off-by: davem-git <[email protected]>
…curity-policy-gateway-api
…ateway into feat-tcp-security-policy-gateway-api
3a2057e to
67814ea
Compare
Signed-off-by: davem-git <[email protected]>
…curity-policy-gateway-api
Signed-off-by: davem-git <[email protected]>
internal/gatewayapi/testdata/tcproute-securitypolicy-with-authorization-client-cidr.in.yaml
Show resolved
Hide resolved
…curity-policy-gateway-api
Signed-off-by: davem-git <[email protected]>
|
LGTM thanks! |
|
/retest |
…curity-policy-gateway-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
…curity-policy-gateway-api
Signed-off-by: davem-git <[email protected]>
85d61b6 to
6753bca
Compare
…curity-policy-gateway-api
|
Fixed a test that was still referencing alpha2, which was removed in this PR. Sorry about that. The update cleared existing approvals. |
|
the coverage test seems like a network timeout failure |
…curity-policy-gateway-api
| for _, listener := range parentRefCtx.listeners { | ||
| irListener := xdsIR[irKey].GetHTTPListener(irListenerName(listener)) | ||
| if irListener != nil { | ||
| switch route.GetRouteType() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious why this code is needed when its NA for TCPRoute, which is checked in validateSecurityPolicyForTCP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which part are you referring to, why we do switch.route? TCP is applied differently with expectedTCPRouteName := strings.TrimSuffix(prefix, "/") , but i don't see that getting applied just continueing if it doesn't match
then there's this line
if target.SectionName != nil && string(*target.SectionName) != r.Destination.Metadata.SectionName {
continue
}```
vs this one for httproute
```go
if target.SectionName != nil && string(*target.SectionName) != r.Metadata.SectionName {
continue
}those have to be different.
let me see if i can reduce the difference
Signed-off-by: davem-git <[email protected]>
…curity-policy-gateway-api
…curity-policy-gateway-api
7a6f78a to
7e601e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
What type of PR is this?
Feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes ##4908
Release Notes: Yes/No
No