feat: notify async runner errors to the main control loop #7189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (45.12%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7189 +/- ##
==========================================
- Coverage 71.04% 71.02% -0.02%
==========================================
Files 229 231 +2
Lines 41099 41144 +45
==========================================
+ Hits 29198 29223 +25
- Misses 10181 10201 +20
Partials 1720 1720 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
Signed-off-by: Ignasi Barrera <[email protected]>
Signed-off-by: Ignasi Barrera <[email protected]>
nacx
force-pushed
the
termiante-errors
branch
from
366b26f to
d8d0531
Compare
|
/retest |
zhaohuabing
reviewed
Oct 17, 2025
Signed-off-by: Ignasi Barrera <[email protected]>
Signed-off-by: Ignasi Barrera <[email protected]>
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR adds the ability to notify async runner errors to the main control loop, so that they can be handled beyond just logging. This is especially useful in the standalone scenario, where one would want to terminate the process when certain errors occur, for example, if the local envoy proxy fails to start.
What this PR does / why we need it:
Which issue(s) this PR fixes:
This helps improve the overall standalone experience for the envoy AI Gateway: envoyproxy/ai-gateway#1304