-
Couldn't load subscription status.
- Fork 579
enable supported conformance test #7291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9b26324
enable supported conformance test
zirain af7fa71
enable BackendTLSPolicyInvalidKind
zirain 25d0eee
fix lint
zirain c52434a
enable BackendTLSPolicyInvalidCACertificateRef
zirain 1b2a984
enable BackendTLSPolicySANValidation
zirain 6165e04
BackendTLSPolicy
zirain 88755a5
fix gen
zirain d059cdb
BackendTLSPolicyObservedGenerationBump
zirain 0ca551a
nit
zirain d7ab5bf
update
zirain c1b3a04
update
zirain 6e718d0
fix gen
zirain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1598,6 +1598,25 @@ func (t *Translator) processDestination(name string, backendRefContext BackendRe | |
|
|
||
| protocol := inspectAppProtocolByRouteKind(routeType) | ||
|
|
||
| // Process BackendTLSPolicy first to ensure status is set. | ||
| tls, tlsErr := t.applyBackendTLSSetting( | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks for making this change so that |
||
| backendRef.BackendObjectReference, | ||
| backendNamespace, | ||
| gwapiv1.ParentReference{ | ||
| Group: parentRef.Group, | ||
| Kind: parentRef.Kind, | ||
| Namespace: parentRef.Namespace, | ||
| Name: parentRef.Name, | ||
| SectionName: parentRef.SectionName, | ||
| Port: parentRef.Port, | ||
| }, | ||
| resources, | ||
| envoyProxy, | ||
| ) | ||
| if tlsErr != nil { | ||
| return nil, nil, status.NewRouteStatusError(tlsErr, status.RouteReasonInvalidBackendTLS) | ||
| } | ||
|
|
||
| switch KindDerefOr(backendRef.Kind, resource.KindService) { | ||
| case resource.KindServiceImport: | ||
| ds, err = t.processServiceImportDestinationSetting(name, backendRef.BackendObjectReference, backendNamespace, protocol, resources, envoyProxy) | ||
|
|
@@ -1612,7 +1631,6 @@ func (t *Translator) processDestination(name string, backendRefContext BackendRe | |
| svc := resources.GetService(backendNamespace, string(backendRef.Name)) | ||
| ds.IPFamily = getServiceIPFamily(svc) | ||
| ds.PreferLocal = processPreferLocalZone(svc) | ||
|
|
||
| case egv1a1.KindBackend: | ||
| ds = t.processBackendDestinationSetting(name, backendRef.BackendObjectReference, backendNamespace, protocol, resources) | ||
| default: | ||
|
|
@@ -1640,24 +1658,7 @@ func (t *Translator) processDestination(name string, backendRefContext BackendRe | |
| } | ||
| } | ||
|
|
||
| var tlsErr error | ||
| ds.TLS, tlsErr = t.applyBackendTLSSetting( | ||
| backendRef.BackendObjectReference, | ||
| backendNamespace, | ||
| gwapiv1.ParentReference{ | ||
| Group: parentRef.Group, | ||
| Kind: parentRef.Kind, | ||
| Namespace: parentRef.Namespace, | ||
| Name: parentRef.Name, | ||
| SectionName: parentRef.SectionName, | ||
| Port: parentRef.Port, | ||
| }, | ||
| resources, | ||
| envoyProxy, | ||
| ) | ||
| if tlsErr != nil { | ||
| return nil, nil, status.NewRouteStatusError(tlsErr, status.RouteReasonInvalidBackendTLS) | ||
| } | ||
| ds.TLS = tls | ||
|
|
||
| var filtersErr error | ||
| ds.Filters, filtersErr = t.processDestinationFilters(routeType, backendRefContext, parentRef, route, resources) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
key changes: set BackendTLSPolicyReasonNoValidCACertificate status