Add erasure of AnyHeapRef-bounded type parameters and better allocator examples - #1227
Open
gsps wants to merge 2 commits into
Open
Add erasure of AnyHeapRef-bounded type parameters and better allocator examples#1227gsps wants to merge 2 commits into
gsps wants to merge 2 commits into
Conversation
…e params in EffectElaboration.
Collaborator
|
@gsps it is more likely to get merged if it targets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves upon the existing
AllocatorMonoexample by a) adding a variantAllocatorMonoAbstractthat abstracts the implementation and simply gives a model of an allocator that could feasibly be used in client code, and b)AllocatorPolyAbstract, a generic variant of the allocator.To achieve the latter, type parameters on classes and functions upper-bounded by
AnyHeapRefare now erased duringEffectElaboration.Drive-by fixes of several bugs in
EffectElaboration.