Skip to content

Implement k8s service labels#227

Open
OCopping wants to merge 12 commits intomainfrom
Implement-k8s-service-labels
Open

Implement k8s service labels#227
OCopping wants to merge 12 commits intomainfrom
Implement-k8s-service-labels

Conversation

@OCopping
Copy link
Contributor

@OCopping OCopping commented Jan 28, 2026

This will display a pod device label in ec monitor if one exists, otherwise it will show default "service" label.
It also bumps textual to be >= v7.4.0

image

@OCopping OCopping requested a review from gilesknap January 28, 2026 14:50
@OCopping OCopping changed the base branch from main to update-copier-template January 28, 2026 15:03
@OCopping OCopping force-pushed the Implement-k8s-service-labels branch 2 times, most recently from 70c57f3 to 7e89ab7 Compare January 28, 2026 15:37
Copy link
Member

@gilesknap gilesknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions, I've not looked at the code yet.

Does this affect ec ps as well as ec monitor?

What is the intention of having device, the IOC name should (sort of) tell you what the device is.

@OCopping
Copy link
Contributor Author

OCopping commented Jan 29, 2026

Does this affect ec ps as well as ec monitor?

Yes it does, so there will be a new label column between name and version.

✗ ec -b DEMO ps     
***RUNNING IN DEMO MODE***
| name       | label          | version | ready | deployed             |
|------------|----------------|---------|-------|----------------------|
| demo-ea-00 | demo device 00 | 1.0.25  | true  | 2024-10-22T11:23:08Z |
| demo-ea-01 | demo device 01 | 1.0.24  | true  | 2024-10-22T11:23:03Z |
| demo-ea-02 | demo device 02 | 1.0.23  | true  | 2024-10-22T11:23:04Z |
| demo-ea-03 | demo device 03 | 1.0.22  | true  | 2024-10-22T11:23:07Z |
| demo-ea-04 | demo device 04 | 1.0.21  | true  | 2024-10-22T11:23:01Z |
| demo-ea-05 | demo device 05 | 1.0.20  | true  | 2024-10-22T11:23:03Z |
| demo-ea-06 | demo device 06 | 1.0.19  | true  | 2024-10-22T11:23:07Z |
| demo-ea-07 | demo device 07 | 1.0.18  | true  | 2024-10-22T11:23:01Z |

What is the intention of having device, the IOC name should (sort of) tell you what the device is.

The scientists on i19 like having a more descriptive label they can just glance at to see what the IOC is for, similar to what was in EDM (although that was more required due to generic IOC names).
I do admit it seems a bit redundant, but the scientists requested something like this 🙃

EDIT: I should add, it would be quite easy to remove from ec ps if you are not a fan of it there.

@OCopping OCopping changed the base branch from update-copier-template to main January 30, 2026 09:15
@gilesknap
Copy link
Member

Lets get this implemented as per our corridor discussion in the up-coming epics-containers sprint.

@gilesknap
Copy link
Member

Do you think this is ready to merge?

I'm a little concerned that this is a breaking change for any beamline not yet on the new version of schema for deployment apps values. (and that version is not even released yet at the time I'm writing this)

We have to work out how to roll this out.

@gilesknap
Copy link
Member

I just tried this but it should now take a 'description' for ec deploy so we can write the label from the CLI.

@OCopping OCopping force-pushed the Implement-k8s-service-labels branch from 6a283d7 to 65cf66c Compare March 4, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants