Conversation
70c57f3 to
7e89ab7
Compare
gilesknap
left a comment
There was a problem hiding this comment.
A couple of questions, I've not looked at the code yet.
Does this affect ec ps as well as ec monitor?
What is the intention of having device, the IOC name should (sort of) tell you what the device is.
Yes it does, so there will be a new ✗ ec -b DEMO ps
***RUNNING IN DEMO MODE***
| name | label | version | ready | deployed |
|------------|----------------|---------|-------|----------------------|
| demo-ea-00 | demo device 00 | 1.0.25 | true | 2024-10-22T11:23:08Z |
| demo-ea-01 | demo device 01 | 1.0.24 | true | 2024-10-22T11:23:03Z |
| demo-ea-02 | demo device 02 | 1.0.23 | true | 2024-10-22T11:23:04Z |
| demo-ea-03 | demo device 03 | 1.0.22 | true | 2024-10-22T11:23:07Z |
| demo-ea-04 | demo device 04 | 1.0.21 | true | 2024-10-22T11:23:01Z |
| demo-ea-05 | demo device 05 | 1.0.20 | true | 2024-10-22T11:23:03Z |
| demo-ea-06 | demo device 06 | 1.0.19 | true | 2024-10-22T11:23:07Z |
| demo-ea-07 | demo device 07 | 1.0.18 | true | 2024-10-22T11:23:01Z |
The scientists on i19 like having a more descriptive label they can just glance at to see what the IOC is for, similar to what was in EDM (although that was more required due to generic IOC names). EDIT: I should add, it would be quite easy to remove from |
|
Lets get this implemented as per our corridor discussion in the up-coming epics-containers sprint. |
|
Do you think this is ready to merge? I'm a little concerned that this is a breaking change for any beamline not yet on the new version of schema for deployment apps values. (and that version is not even released yet at the time I'm writing this) We have to work out how to roll this out. |
|
I just tried this but it should now take a 'description' for ec deploy so we can write the label from the CLI. |
6a283d7 to
65cf66c
Compare
…ously added description label
Includes refactor to check_stoppable
This will display a pod
devicelabel in ec monitor if one exists, otherwise it will show default "service" label.It also bumps textual to be >= v7.4.0