Add a data type UINT16_BS : byte swapped in unsigned 16-bit integers#37
Open
lvhuihui1988 wants to merge 1 commit intoepics-modules:masterfrom
Open
Add a data type UINT16_BS : byte swapped in unsigned 16-bit integers#37lvhuihui1988 wants to merge 1 commit intoepics-modules:masterfrom
lvhuihui1988 wants to merge 1 commit intoepics-modules:masterfrom
Conversation
Member
|
What type of computer are you running the Modbus driver on (for example Intel x64 with Linux, etc.)? I want to make sure the problem is not with the endianness of the Modbus client. The Modbus specification is very clear that 16-bit values should be transmitted in network byte order, i.e. big-endian. The Modbus driver converts to the endianness of the host. |
Author
|
We use Linux x86-64. |
Member
|
I think for completeness we should also add INT16_BS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PLC we used stores a word as an unsigned 16-bit integer. But bytes with this 16-bit register are swapped. This data type is not supported by Modbus. Therefore, I modified the source code to support 16-bit unsigned intergers with swapped bytes within a word. I add a new data type called UINT16_BS.