-
Notifications
You must be signed in to change notification settings - Fork 2
Define "_Row" and "_Column" in the registry #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
70db174
Search in registry "_Row" and "_Column"
exacs b9e48a7
Merge branch 'main' into feature/CMS-44289-global-row-column
exacs 8a25e28
Define more components for Row and Column
exacs fd2daac
Update test-website
exacs af33c52
Define DTs for section, row and column
exacs 19d0c85
Ensure DTKey works for BlankSection
exacs 7f04a19
Remove console.log
exacs 4e26b3d
Remove `nodes` type check
exacs f6b438a
Rename nodes > node.nodes to avoid confusion
exacs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,56 +1,3 @@ | ||
| import { | ||
| BlankSection, | ||
| Component1, | ||
| Component1A, | ||
| Component1B, | ||
| Component2, | ||
| Component2A, | ||
| Component3, | ||
| Component3C, | ||
| ct1, | ||
| ct2, | ||
| ct3, | ||
| dt1, | ||
| dt2, | ||
| dt3, | ||
| } from '@/components/with-display-templates'; | ||
| import { | ||
| initContentTypeRegistry, | ||
| initDisplayTemplateRegistry, | ||
| } from '@optimizely/cms-sdk'; | ||
| import { initReactComponentRegistry } from '@optimizely/cms-sdk/react/server'; | ||
| import RootLayout from '@/app/en/layout'; | ||
|
|
||
| initContentTypeRegistry([ct1, ct2, ct3]); | ||
| initDisplayTemplateRegistry([dt1, dt2, dt3]); | ||
| initReactComponentRegistry({ | ||
| resolver: { | ||
| test_c1: { | ||
| default: Component1, | ||
| tags: { | ||
| tagA: Component1A, | ||
| tagB: Component1B, | ||
| }, | ||
| }, | ||
| test_c2: Component2, | ||
| 'test_c2:tagA': Component2A, | ||
| test_c3: { | ||
| default: Component3, | ||
| tags: { | ||
| tagC: Component3C, | ||
| }, | ||
| }, | ||
| BlankSection: BlankSection, | ||
| }, | ||
| }); | ||
|
|
||
| export default function RootLayout({ | ||
| children, | ||
| }: Readonly<{ | ||
| children: React.ReactNode; | ||
| }>) { | ||
| return ( | ||
| <html lang="en"> | ||
| <body>{children}</body> | ||
| </html> | ||
| ); | ||
| } | ||
| export default RootLayout; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,3 @@ | ||
| export const metadata = { | ||
| title: 'Next.js', | ||
| description: 'Generated by Next.js', | ||
| } | ||
| import RootLayout from '@/app/en/layout'; | ||
|
|
||
| export default function RootLayout({ | ||
| children, | ||
| }: { | ||
| children: React.ReactNode | ||
| }) { | ||
| return ( | ||
| <html lang="en"> | ||
| <body>{children}</body> | ||
| </html> | ||
| ) | ||
| } | ||
| export default RootLayout; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.