add dxAdjust in PendleCurveRouter #212
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| if (input.curveDxAdjustPtToToken >= CURVE_DX_ADJUST_ONE) revert WrongInput(); | ||
| if (input.curveDxAdjustPtToToken + CURVE_DX_ADJUST_ONE < 0) revert WrongInput(); | ||
| if (input.curveDxAdjustTokenToPt >= CURVE_DX_ADJUST_ONE) revert WrongInput(); | ||
| if (input.curveDxAdjustTokenToPt + CURVE_DX_ADJUST_ONE < 0) revert WrongInput(); |
There was a problem hiding this comment.
Can we use abs method from @openzeppelin/contracts/utils/math/SignedMath.sol? Then the condition input.curveDxAdjustPtToToken.abs() >= CURVE_DX_ADJUST_ONE will be more readable
There was a problem hiding this comment.
Moreover right now you forbid curveDxAdjustPtToToken = CURVE_DX_ADJUST_ONE value, however the -CURVE_DX_ADJUST_ONE will pass
| } = await initializeRouter()); | ||
| }); | ||
|
|
||
| it.only('Curve check route', async () => { |
| // Route to make swap pt-stETH -> stETH -> ETH -> WETH | ||
| const routeInput: PendleCurveRouterNgAdapter.RouteInputStruct = { | ||
| pendleMarket: pendleMarket, | ||
| slippage: 35, // 20/100 = 20% |
There was a problem hiding this comment.
wrong comment or am I missing something?
| // Tests for running in ethereum mainnet fork | ||
| describe('Pendle PT-STETH - wETH', () => { | ||
| before(async () => { | ||
| //await resetFork(22388154); //2025-05-02 |
| const quoteTokenIn = parseUnits('0.1', 18); | ||
| await quoteToken.connect(user).approve(router.address, quoteTokenIn); | ||
|
|
||
| const minPtOut = parseUnits('0.1', 18); //parseUnits('900', 18); |
No description provided.