Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIA-8189 - adding new metricsNames and cloudEventsTypes #27

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

EIA-8189 - adding new metricsNames and cloudEventsTypes #27

wants to merge 2 commits into from

Conversation

kmajewski2-equinix
Copy link

Checklist

  • [✅] I have read the CONTRIBUTING.md
  • [✅ ] I certify that my preview and released lists for Events/Metrics/Alerts are correct
  • [N/A] I certify that all Events/Metrics/Alerts in released are properly tested and ready for production

@kmajewski2-equinix kmajewski2-equinix requested a review from a team as a code owner February 27, 2025 16:49
ryli17
ryli17 requested changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@ryli17 ryli17 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is incorrect.

  1. Don't modify DataLoader.json, catalog.json, and README.md directly. They are automatically generated.
  2. I saw that internet_access is under fabric domain already. Please add the new types to corresponding json file under fabric/v1

@kmajewski2-equinix kmajewski2-equinix requested a review from a team as a code owner February 28, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryli17 ryli17 ryli17 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmajewski2-equinix @ryli17