-
Couldn't load subscription status.
- Fork 70
feat(eds-core-react): typography #4125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Paragraph components
…es and add new Patterns story
…mport requirement
…n typography components
…ries.tsx Co-authored-by: Copilot <[email protected]>
…ography component
… readability and maintainability in typography.css
…nd component to include debug prop
pomfrida
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the new typography system @torleifhalseth ! ✨
Really liked theuseDeprecationWarning hook, that's very nifty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new, next-generation typography system for the design system’s React components, including new
Heading,Paragraph, andTypographyNextcomponents. It also updates the build system and documentation to support and promote these new components, while marking the old typography component as deprecated. The changes improve performance, accessibility, and developer experience by providing more semantic, flexible, and maintainable typography options.New Typography System
Heading: For semantic heading elements (h1–h6) with design system styles. (Heading.tsx,Heading.types.ts,Heading.stories.tsx) [1] [2] [3]Paragraph: For block-level paragraph text with UI font family. (Paragraph.tsx,Paragraph.types.ts,Paragraph.stories.tsx) [1] [2] [3]TypographyNext: For flexible, inline text with full control over typography properties and baseline grid alignment. (Typography.new.tsx,Typography.new.stories.tsx) [1] [2]README.md,Typography.docs.mdx,Typography.new.stories.tsx,Heading.stories.tsx,Paragraph.stories.tsx) [1] [2] [3] [4] [5]Deprecation and Migration Guidance
Typographycomponent as deprecated and provided clear migration instructions to the new system in both documentation and Storybook. [1] [2]Build and Style System Updates
style.cssfor the new typography system, and exposed it via package exports for easy import. (rollup.config.js,package.json) [1] [2] [3]postcss-importconfiguration for CSS processing. (rollup.config.js,package.json) [1] [2]preview.css,preview.mjs,.storybook/main.mjs) [1] [2] [3]Miscellaneous
.vscode/settings.json)vitest.config.ts,package.json) [1] [2]These changes set the foundation for a more robust, accessible, and future-proof typography system in the design system library.