fix(eds-core-react): 🐛 Update Tooltip component to use mergeRefs #4130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomfrida
requested review from
Chibuzor-Nwemambu,
millus,
torleifhalseth and
vnys
as code owners
|
👀 Currently debugging why CI won't use the updated snapshot as a ref for comparison. |
This fixes the warning related to accessing element.ref directly, which is no longer supported in React 19.
pomfrida
force-pushed
the
4128-tooltip-not-rendered-when-children-has-ref
branch
from
f55d5de to
ead6ee8
Compare
|
This did the trick, now the snapshot test is passing in CI as well |
Chibuzor-Nwemambu
approved these changes
Oct 22, 2025
Merged
pomfrida
added a commit
that referenced
this pull request
Oct 22, 2025
* fix(eds-core-react): 🐛 Update Tooltip component to use mergeRefs This fixes the warning related to accessing element.ref directly, which is no longer supported in React 19. * Add test to cover ref issue * chore: trigger CI rebuild after main branch migration * test: Use explicit ID in Tooltip snapshot test for consistency * Try to remove id to make snapshot deterministic * Fix prettier * resolve eslint errors in tooltip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was not able to reproduce the issue with the Tooltip not rendering or being misplaced as described in the original report, the changes made do address the React 19 compatibility warnings related to ref handling. Tooltip now properly handles refs on child components without triggering warnings, ensuring it works as expected in React 19 environments while maintaining its core functionality and behavior.
Resolves #4128