fix: SubsurfaceViewer, ViewStateType missing properties #2667
+38
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added width, height, minRotationX, and maxRotationX properties to the ViewStateType interface.
Collaborator
|
Looks good! I think it would be great if we also could add comments to the properties to describe what they represent. |
Expanded the ViewStateType interface with descriptive JSDoc comments for each property.
Contributor
Author
|
@rubenthoms Thanks for the recommendation. I added the JSDoc comments for the properties. I'll be waiting for feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added width, height, minRotationX, and maxRotationX properties to the ViewStateType interface.
Related to: #2666.