fix: "SubsurfaceViewer: pickingRadius not working with overlapping la… #2669
Conversation
| coords, | ||
| showReadout = coords?.visible ?? true, | ||
| pickingDepth = coords?.pickDepth ?? 2, | ||
| pickingDepth = coords?.pickDepth ?? 5, |
There was a problem hiding this comment.
Why changing the default value ?
Does it really fix anything ?
There was a problem hiding this comment.
No this doesn't fix anything. 2 is barely mutlipicking. 10 is the default from deck.gl. It can affect performance if set to high. Of course its only a defaul value. I dont have any strong feelings about it.
There was a problem hiding this comment.
I think I remember you did set to 2 for performance reason.
If there is no impact on this PR, reset it to 2 please.
typescript/packages/subsurface-viewer/src/layers/map/privateMapLayer.ts
Outdated
Show resolved
Hide resolved
| return [0, 0, 0]; | ||
| } | ||
|
|
||
| decodePickingColor(/*color: Uint8Array*/): number { |
There was a problem hiding this comment.
is this used ? If not, remove it
There was a problem hiding this comment.
Used by deck,gl to in this case map all colors to index zero. (As this layer does not have multiple index's)
There was a problem hiding this comment.
Add that in a comment, please.
|
Note. I may have to do this fix also for other non standard layers but prefer to do this in a separate PR |
| return [0, 0, 0]; | ||
| } | ||
|
|
||
| decodePickingColor(/*color: Uint8Array*/): number { |
There was a problem hiding this comment.
Add that in a comment, please.
2 participants
…yers #2320"