Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submit stage file browser #74

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

sdc50
Copy link
Member

@sdc50 sdc50 commented Feb 11, 2025

Changes the advanced options view of the submit stage dynamically create either an HpcFileBrowser or an AsyncHpcFileBrowser object depending on the type of uit_client.

Also updated the dynamic hiding and showing of the file browser to play better with Panel 1.x

@sdc50 sdc50 force-pushed the fix_submit_stage_file_browser branch from c793916 to 0c7f04b Compare February 11, 2025 22:41
Copy link
Collaborator

@araglu araglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I tried it out and didn't find any bugs.

I was thinking of tweaking some of the tooltips, but I can't think of better wording.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants