-
Notifications
You must be signed in to change notification settings - Fork 74
Mini-Challenge 2: Intro to Testing #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
erickwize
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments
I can see you started to create some tests for the components using enzyme and it is ok, but we encourage you to use React Testing Library.
I have the same recommendation of creating the PR into your own Github repo so we can merge it when it is approved or done.
Also please add a file with the coverage of the tests for the following deliverables.
Acceptance Criteria
- Meaningful test cases were implemented for components and sub-routines logic.
- All the test cases were successful.

It failed only a snapshot (not a big deal - you can update it with the new UI)
Bonus Points
- Test coverage is above 60%.
Mini-Challenge 2: Intro to Testing
Answer the following questions first
1. Using
create-react-app, what do we need to set up for testing?2. What components are worth testing in your development?
3. Can you apply TDD once you already created components?
The Challenge
Acceptance Criteria
Bonus Points