Minichallenge_1 #25
Open
Minichallenge_1 #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi Edgar, thank you for submitting your Pull Request, I left small comments in it.
Also here are some missing points you can work on for the next deliverables:
- Try to add unit tests
- Avoid commits on master branch directly, you can create a feature branch on your fork, and then create the Pull request with master in your own repo
| const StyledHeader = styled.header` | ||
| background-color: rgb(247, 247, 247); | ||
| display: flex; | ||
| border-bottom: 1px solid rgb(236, 236, 236 ) !important; |
Comment on lines
49
to
50
| width: 40px important!; | ||
| height: 40px important!; |
| const CardContent = styled.div` | ||
| overflow: hidden; | ||
| border-radius: 2px; | ||
| border: 1px solid rgb(236, 236, 236 ) !important; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development of minichallenge 1