Skip to content

Conversation

@Fetrelo
Copy link

@Fetrelo Fetrelo commented Mar 20, 2021

Added tests

@ragrum
Copy link

ragrum commented Mar 26, 2021

When working with dependent pull-request you can use stacked pull-requests.

@ragrum
Copy link

ragrum commented Mar 26, 2021

If you're using npm to install your dependencies then package-lock.json should be committed, but it's not. Disregard this comment if you're using something else.

describe('Ensure elements get rendered', () => {
it('Title', () => {
render(<HomePage />);
expect(screen.getByText(/YouTube video search app/, {selector: 'h1'})).toBeInTheDocument();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to use getByRole query.

import Toggle from '../components/CustomInputs/Toggle';
import Nav from '../components/Nav';

describe('Nav tests', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants