-
Notifications
You must be signed in to change notification settings - Fork 74
Mini-Challenge 2: Intro to Testing #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…erable are being removed from the project. Anyway, they will be added whenever it's needed.
…d. Responsiveness on header is still pending.
|
When working with dependent pull-request you can use stacked pull-requests. |
|
If you're using |
src/__tests__/homepage.test.js
Outdated
| describe('Ensure elements get rendered', () => { | ||
| it('Title', () => { | ||
| render(<HomePage />); | ||
| expect(screen.getByText(/YouTube video search app/, {selector: 'h1'})).toBeInTheDocument(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer to use getByRole query.
src/__tests__/nav.test.js
Outdated
| import Toggle from '../components/CustomInputs/Toggle'; | ||
| import Nav from '../components/Nav'; | ||
|
|
||
| describe('Nav tests', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could write fewer, longer tests.
Refactorized tests.
Added tests