Daniela López. 1st challenge #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielaZrLC
changed the title
jonathanperazawl
left a comment
jonathanperazawl
left a comment
There was a problem hiding this comment.
Looking good, I left small comments, also try to add more test cases for smaller components.
Comment on lines
+1
to
+15
| // import './global.css'; | ||
| // import Header from '../src/pages/Header/Header'; | ||
| // import Home from './pages/Home/Layout/Layout'; | ||
| // import 'antd/dist/antd.css' | ||
|
|
||
| // function App() { | ||
| // return ( | ||
| // <div> | ||
| // <Header/> | ||
| // <Home/> | ||
| // </div> | ||
| // ); | ||
| // } | ||
|
|
||
| // export default App; |
There was a problem hiding this comment.
Remove the file if it is no needed
Comment on lines
+17
to
+25
| /* .container { | ||
| width: 100vw; | ||
| height: 100vh; | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| align-items: center; | ||
| margin-top: -3rem; | ||
| } */ |
There was a problem hiding this comment.
Same here, remove unused comments.
| @@ -0,0 +1,14 @@ | |||
| // Light mode Colors | |||
There was a problem hiding this comment.
What about creating themes instead, something like:
const themes = {
dark: {
primary: ...
},
light: {
primary: ...
}
}Then you can re-use this them among all your components and styled components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.